[GNC-dev] Windows build has failed

[John Ralls]

> On Jan 21, 2021, at 6:35 AM, Robert Fewell <14ubobit at gmail.com> wrote:
> 
> Hi,
> 
> The Windows nightly build has failed since the libofx upgrade.
> Fails at...
> 
> C:/gcdev64/gnucash/maint/src/libofx-0.10.0/lib/ofx_preproc.cpp:317:39:
> error: invalid conversion from 'const char**' to 'char**'
> [-fpermissive]
>  317 |                                       &inchar, &inbytesleft,
>      |                                       ^~~~~~~
>      |                                       |
>      |                                       const char**
> 
> I had a look at the same file in the previous version and on line 310
> a change was made...
> 
> Old version...
> #if defined(__sun) || defined(__NetBSD__)
> 
> New version...
> #if defined(__WIN32__) || defined(__sun) || defined(__NetBSD__)
> 
> I changed that line to the old version and was able to build libofx
> and continue to build successfully.
> 
> Not sure if that is a valid fix?

It's not. https://github.com/libofx/libofx/pull/38 is.

Regards,
John Ralls