Revert Linas' broken changes to qof.

Derek Atkins warlord at MIT.EDU
Sun Apr 18 23:13:07 EDT 2004

linas at (Linas Vepstas) writes:

> You need to make clean; make; make install

I tried with a clean checkout; it didn't build for a number
of reasons:  Transaction.c had some incorrect settings,
and then in gnome-utils you had an incorrect number of
arguments to the functions.

Even worse, you were illegally calling functions of one argument with
TWO arguments, and the compiler wasn't catching it due to the casting.
This is BAD, and can lead to LOTS of problems down the road.

> Then the code will build correctly, and gnucash will work just fine.
> If there is some specific bug that results, let me know.  But is
> passes a variety of tests, including gnucash 'make check'

Uh, no, it wont.  It broke in both src/engine (Transaction.h)
and gnome-utils (gnc-query-list.c).

> I'm guessing that what happened to you is that you linked 
> a gnucash binary to older gnucash files in /usr/liocal/lib.
> This will break, because the qof structs have changed in size,
> and so you will get all sorts of weird core dumps.

Nope.  This isn't what happened.  It was a compile-time break,
not a runtime break!

> --linas


       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL:    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available

More information about the gnucash-patches mailing list