Revert Linas' broken changes to qof.
linas at linas.org
Sun Apr 18 23:31:05 EDT 2004
On Sun, Apr 18, 2004 at 11:13:07PM -0400, Derek Atkins was heard to remark:
> linas at linas.org (Linas Vepstas) writes:
> > You need to make clean; make; make install
> I tried with a clean checkout; it didn't build for a number
> of reasons: Transaction.c had some incorrect settings,
umm, ahh, rechecking again now.
> Even worse, you were illegally calling functions of one argument with
> TWO arguments, and the compiler wasn't catching it due to the casting.
> This is BAD, and can lead to LOTS of problems down the road.
Its no worse than the function signature casting that is
already being done. The second argument is not clobbered
for the caller, because the callee linkage saves all clobbered
registers, and the callee couldn't care less, because it
saves and restores all registers that it clobbers. It's
perfectly safe; I've read the assembly umpteen times over
the years. Take a look at GTK signals, where this is done
all over the place; the added extra argument is usually
a gpointer to 'user-data'.
> Uh, no, it wont. It broke in both src/engine (Transaction.h)
> and gnome-utils (gnc-query-list.c).
I uhh, guess I needed to check some other things in too ....
pub 1024D/01045933 2001-02-01 Linas Vepstas (Labas!) <linas at linas.org>
PGP Key fingerprint = 8305 2521 6000 0B5E 8984 3F54 64A9 9A82 0104 5933
More information about the gnucash-patches