HEAD - QOF sync patch.
Derek Atkins
warlord at MIT.EDU
Sun Jan 30 13:09:26 EST 2005
Neil Williams <linux at codehelp.co.uk> writes:
> So if I send a replacement patch that deals with this problem:
>
>> --- ./src/engine/test-core/test-engine-stuff.c Fri Dec 17 15:56:30 2004
>> +++ ./src/engine/test-core/test-engine-stuff.c Mon Dec 20 15:01:29 2004
>
> The rest is OK to apply?
uh, I didn't look at anything beyond that point. The stuff before it
all looked okay at a cursory glance.
>> Are you sure you were working from an up-to-date cvs tree?
>
> Yes, the rest of the tree is up to date - I just missed that one file. Sorry.
NP. Just making sure.. It's a long patch to audit, and god knows
I've missed simple bugs in my auditing in the past.
>> Also,
>> unless you're adding new files you're MUCH MUCH MUCH better off just
>> sending in a "cvs diff -q" output. It's shorter and less prone to
>> errors like these.
>
> I thought you wanted makepatch format? To send cvs diff output I've copied my
> checked out copy, and applied the makepatch to it then done:
> cvs -q diff -u > /opt/export/patches/gnucash/derek1.patch
No, I prefer "cvs diff". The only exception to this is when you are
adding a new file at which point I prefer makepatch (because cvs diff
doesn't really handle that case very well).
I'll look at this patch later this afternoon and (hopefully) apply it.
-derek
--
Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
Member, MIT Student Information Processing Board (SIPB)
URL: http://web.mit.edu/warlord/ PP-ASEL-IA N1NWH
warlord at MIT.EDU PGP key available
More information about the gnucash-patches
mailing list