HEAD - QOF sync patch.

Derek Atkins warlord at MIT.EDU
Sun Jan 30 15:58:38 EST 2005


Applied.  I had to make one change to get it to compile properly.
There's no definition for qofAccountSetParent() so I made it a
static function.  I'll commit it with that change once the build
completes.

-derek

Neil Williams <linux at codehelp.co.uk> writes:

> On Sunday 30 January 2005 4:05 pm, you wrote:
>> Unfortunately this patch also breaks a bunch of the C99 changes
>> that were put into the code.
>
> OK, I got src/engine/test-core/test-engine-stuff.c wrong, sorry, that was an 
> error in merging the trees - it was trying to undo the very change I wanted.
>
> However, the other changes to ./src/engine/qofquery-deserial.c 
> and ./src/engine/qofquery-serialize.c are doing the right thing, aren't they? 
> Moving the declarations to the top of the function.
>
> So if I send a replacement patch that deals with this problem:
>
>> --- ./src/engine/test-core/test-engine-stuff.c  Fri Dec 17 15:56:30 2004
>> +++ ./src/engine/test-core/test-engine-stuff.c  Mon Dec 20 15:01:29 2004
>
> The rest is OK to apply?
>
>> Are you sure you were working from an up-to-date cvs tree?
>
> Yes, the rest of the tree is up to date - I just missed that one file. Sorry.
>
>> Also, 
>> unless you're adding new files you're MUCH MUCH MUCH better off just
>> sending in a "cvs diff -q" output.  It's shorter and less prone to
>> errors like these.
>
> I thought you wanted makepatch format? To send cvs diff output I've copied my 
> checked out copy, and applied the makepatch to it then done:
> cvs -q diff -u > /opt/export/patches/gnucash/derek1.patch
>
> (I've sorted out the error above.)
>
>> -derek
>
>
> -- 
>
> Neil Williams
> =============
> http://www.dcglug.org.uk/
> http://www.nosoftwarepatents.com/
> http://sourceforge.net/projects/isbnsearch/
> http://www.neil.williamsleesmill.me.uk/
> http://www.biglumber.com/x/web?qs=0x8801094A28BCB3E3
>
>

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-patches mailing list