gnucash maint: Multiple changes pushed

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/3138229c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/06db9bcf (commit)
	from  https://github.com/Gnucash/gnucash/commit/51d1bc77 (commit)



commit 3138229cf6c2e097731cc10b010b5035304fbf6f
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Apr 17 23:04:18 2018 +0200

    A few whitespace fixups

commit 06db9bcf2b68c9477ea3a75ded16c27597deadd0
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Apr 17 23:03:31 2018 +0200

    Fix crash when loading sql book with posted transactions
    
    This crash started to appear as of commit 80dbb9940b77d because the sequence
    of split loading has changed as a result of the query optimizations.
    Invoice transactions get loaded before the general transaction loading happens.
    However because of this, when an invoice transaction was encountered again
    during general transaction loading, it was (correctly) not created again
    AND (incorrectly) not opened for subsequent editing. This caused
    an assert to fail when the splits for this transaction are loaded
    shortly afterwards. The solution is simply to ensure all transactions
    are opened for editing during the general transaction loading call.



Summary of changes:
 libgnucash/backend/sql/gnc-transaction-sql.cpp | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)