gnucash maint: Multiple changes pushed

John Ralls jralls at
Tue Apr 17 19:32:54 EDT 2018

Updated	 via (commit)
	 via (commit)
	from (commit)

commit cad6bb42726c20a21b88e3ec4ee246dc3d9125c4
Author: John Ralls <jralls at>
Date:   Tue Apr 17 16:27:24 2018 -0700

    Bug 792105 - Startup takes several minutes, take two.
    First, remove the unnecessary locale push & pop on <CT_TIME64>load.
    Second, the registry accesses were caused by using g_win32_get_locale
    to convert the Microsoft locale strings to POSIX ones. We don't care
    what kind of string we get as long as we can pass it back to setlocale,
    so remove that.
    Third, gnc_push/pop_locale were used only in backend/dbi in a
    very limited way and did much more than was necessary, so
    convert them to C++ inlines in gnc-backend-dbi.hpp that does
    only what we need them to.

commit 39aecb7610fe9e5241f7ab77e99cf86ed53f36a9
Author: John Ralls <jralls at>
Date:   Tue Apr 17 12:02:04 2018 -0700

    Bug 794936 - 3.0 does not open previously saved sqlite3 files...
    properly - corrupted business data
    Turned out to be a pointer/value mismatch between <CT_NUMERIC>load()
    and most of the setter functions, so the address was getting set
    as the value.

Summary of changes:
 libgnucash/backend/dbi/gnc-backend-dbi.cpp         |  6 ++--
 libgnucash/backend/dbi/gnc-backend-dbi.hpp         | 15 ++++++++
 libgnucash/backend/dbi/gnc-dbisqlconnection.cpp    |  4 +--
 libgnucash/backend/dbi/gnc-dbisqlresult.cpp        | 10 +++---
 libgnucash/backend/sql/gnc-slots-sql.cpp           |  6 ++--
 .../backend/sql/gnc-sql-column-table-entry.cpp     | 14 ++++++--
 libgnucash/core-utils/gnc-locale-utils.c           | 40 ----------------------
 libgnucash/core-utils/gnc-locale-utils.h           | 22 ------------
 8 files changed, 39 insertions(+), 78 deletions(-)

More information about the gnucash-patches mailing list