gnucash maint: Multiple changes pushed

[Christopher Lam]

Updated	 via  https://github.com/Gnucash/gnucash/commit/bb6d84e0 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/463c3124 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/b9382d2c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/e783335c (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dd1873eb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/4214f7eb (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1e66d3b2 (commit)
	from  https://github.com/Gnucash/gnucash/commit/bc1bcc71 (commit)



commit bb6d84e03d5920d79c63e446eb145050f741c715
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jul 5 21:54:38 2019 +0800

    [html-utilities] [API] further deprecations
    
    * gnc:html-build-acct-table -- unused for decades
    * gnc:html-table-append-ruler/markup
    * gnc:html-acct-table-row-helper!
    * gnc:html-acct-table-comm-row-helper!

commit 463c3124ef51fc5d7ec4c349dd2646f7b9ad1ffa
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jul 5 21:50:52 2019 +0800

    [commodity-utilities] [API] deprecate gnc:sum-collector-stocks
    
    this function is never reachable in code

commit b9382d2cf22ae1549f144bd64b1fe9b7bfcaa3f5
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jul 6 18:20:18 2019 +0800

    [commodity-utilities] move gnc:debug to less CPU critical code
    
    pricealist is a long list generated once, yet is dumped via gnc:debug
    for every call to gnc:exchange-by-pricealist-nearest. This change
    moves gnc:debug to the initial pricealist generation, ensuring that
    gnc:exchange-by-pricealist-nearest is much faster.

commit e783335cf26521fd9faa5854d3393e51bd880a43
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jul 5 23:09:19 2019 +0800

    [commodity-utilities] compact gnc:sum-collector-commodity
    
    This function converted to purely functional approach.
    
    Note that commodity-collectors always round amounts to the currency
    SCU therefore we replicate the behaviour here.

commit dd1873eb0571848d1e40be5316ae8155372c82dd
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jul 5 23:09:12 2019 +0800

    [test-cash-flow] fix test which was badly designed
    
    this test had confused 2 functions:
    
    (exchange-fn monetary currency) --> monetary
      and
    (to-report-currency currency amount date) --> amount
    
    this flaw surfaces with the shortened gnc:sum-collector-commodity definition.

commit 4214f7eb76cc899e475b9af3b2790d8528a269dd
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Sat Jul 6 14:32:53 2019 +0800

    [balsheet-pnl] bugfix prevent crash on missing accts
    
    When asset/liability/income/expense accounts are either missing or
    deselected, the report would crash. This commit will ensure the
    date-specific balance calculators do not crash.
    
    The reason for crash is the form (apply map gnc:monetaries-add lists)
    where lists is usually a list-of-list-of-monetaries, e.g.
    (list (list $1.00 $2.00 $3.00)
          (list $2.35 $3.44 $4.45))
    
    and (apply map gnc:monetaries-add lists) will return a list of the
    matched sums, i.e. commodity-collectors (list (list <$3.35> <$5.44>
    <$7.45>)), whereby each commodity-collector is denoted by <...>
    
    When there are missing account-types (or deselected) the lists are
    empty-lists, therefore mapping will fail. This change ensures that
    null-lists are handled by returning (list (list <> <> <>)), with null
    commodity-collectors.

commit 1e66d3b2f6406814efa185bc62cea4252fd79d45
Author: Christopher Lam <christopher.lck at gmail.com>
Date:   Fri Jul 5 21:45:44 2019 +0800

    [balsheet-pnl] cosmetic: improve maxindent calc
    
    75ab45ac3 without 1+ some alignment is incorrect



Summary of changes:
 .../report/report-system/commodity-utilities.scm   | 28 +++++++--------
 gnucash/report/report-system/html-utilities.scm    |  8 +++++
 gnucash/report/standard-reports/balance-sheet.scm  |  6 +---
 gnucash/report/standard-reports/balsheet-pnl.scm   | 40 ++++++++++++++--------
 .../standard-reports/test/test-cash-flow.scm       | 13 +++----
 5 files changed, 54 insertions(+), 41 deletions(-)