gnucash master: Multiple changes pushed

[Geert Janssens]

Updated	 via  https://github.com/Gnucash/gnucash/commit/a982b60f (commit)
	 via  https://github.com/Gnucash/gnucash/commit/6993fed2 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/dae07fba (commit)
	 via  https://github.com/Gnucash/gnucash/commit/1d971c15 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/545f27c5 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/aa0a68fd (commit)
	 via  https://github.com/Gnucash/gnucash/commit/be0579dc (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9df059e9 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/c6a93903 (commit)
	 via  https://github.com/Gnucash/gnucash/commit/003f379d (commit)
	 via  https://github.com/Gnucash/gnucash/commit/9e1268d9 (commit)
	from  https://github.com/Gnucash/gnucash/commit/232dd765 (commit)



commit a982b60f17f7b4af90db72148e46159a06feb6f5
Merge: 232dd7656 6993fed22
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 18:21:24 2023 +0100

    Merge branch 'CsvTransImpExp'

commit 6993fed22974d2465b8507c40b728bb526a7da0b
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 17:58:05 2023 +0100

    CsvTransExp - fix info message to match state of simple format button

commit dae07fba993c21b55607404a99d890e91c96b1dc
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 17:32:52 2023 +0100

    CsvTransExp - treat single account as list of accounts with one element
    
    That allows to remove another tracking variable.

commit 1d971c157887e81afc2720edec8f90a0e6cfa6ff
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 17:24:11 2023 +0100

    CsvTransExp - remove redundant counter num_accounts
    
    Simply use length of account list instead

commit 545f27c5500a4bb3e1068c629c3ed89251ce9704
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 16:52:13 2023 +0100

    CsvTransExp - limit scope of variable to actual use

commit aa0a68fd1c67c0e0aed21e2193ecf35107745dcc
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 16:47:18 2023 +0100

    CsvTransExp - repeat transaction details on every line in multi-line mode
    
    The GnuCash Csv Importer can deal with both cases,
    but there has been user feedback that the format
    with only the first line displaying transaction
    details is confusing and/or not readily usable
    in external tools.

commit be0579dc0cde794ffef05316011c399d105d8f22
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 16:40:48 2023 +0100

    CsvTransExport - more generic code cleanup
    
    - declare variables on use
    - more concise tests and loops
    - drop unused includes
    - gboolean->bool

commit 9df059e9a5f60d0cf99a937940e88977c7b0e4c8
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 14:52:59 2023 +0100

    CsvTransExport - omit trading splits unless exporting from a trading account

commit c6a93903b3495a124e7d8515fb7effb34db79fa8
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 12:45:56 2023 +0100

    CsvTransExport - generic code cleanup
    
    - declare variables on use
    - more concise tests and loops

commit 003f379d88785af7cb181ac197bf058d52641b45
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 11:43:46 2023 +0100

    Bug 798600 - CSV import of multi-split security transactions fails to load capital gain - part 2
    
    Update csv transaction export format to include split values.
    In the csv importer the 'GnuCash Export Format' option will
    now include values. For compatibility with filex exported
    from older gnucash versions the previous preset is still
    available under the name 'GnuCash Export Format (4.x and older)'.

commit 9e1268d9347f9375865a5f52becb9d52f23eb3ad
Author: Geert Janssens <geert at kobaltwit.be>
Date:   Tue Feb 14 10:40:42 2023 +0100

    Bug 798600 - CSV import of multi-split security transactions fails to load capital gain - part 1
    
    Transactions with capital gains processing can have
    splits in transaction currency with a zero amount
    and a non-zero value. To properly import those,
    prefer the value column even if transaction
    currency equals account commodity.
    Previous (wrong) assumption was that in case
    of a same-currency split, the amount would
    always be the value.



Summary of changes:
 .../import-export/csv-exp/assistant-csv-export.c   |  69 ++-
 .../import-export/csv-exp/assistant-csv-export.h   |   4 +-
 .../csv-exp/csv-transactions-export.c              | 480 +++++++++------------
 gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp |   6 +-
 .../csv-imp/gnc-imp-settings-csv-tx.cpp            |  37 ++
 .../import-export/csv-imp/gnc-imp-settings-csv.cpp |   6 +
 .../import-export/csv-imp/gnc-imp-settings-csv.hpp |   1 +
 7 files changed, 284 insertions(+), 319 deletions(-)