gnucash master: Multiple changes pushed
John Ralls
jralls at code.gnucash.org
Thu Feb 16 16:10:33 EST 2023
Updated via https://github.com/Gnucash/gnucash/commit/ec6d38ae (commit)
via https://github.com/Gnucash/gnucash/commit/3a3cf05a (commit)
via https://github.com/Gnucash/gnucash/commit/9c6ad222 (commit)
via https://github.com/Gnucash/gnucash/commit/05975aa5 (commit)
via https://github.com/Gnucash/gnucash/commit/f7027094 (commit)
via https://github.com/Gnucash/gnucash/commit/1204083f (commit)
via https://github.com/Gnucash/gnucash/commit/0aad5696 (commit)
via https://github.com/Gnucash/gnucash/commit/083166b5 (commit)
via https://github.com/Gnucash/gnucash/commit/4eb022c7 (commit)
via https://github.com/Gnucash/gnucash/commit/8a20bcad (commit)
via https://github.com/Gnucash/gnucash/commit/56d95059 (commit)
via https://github.com/Gnucash/gnucash/commit/f63dddcc (commit)
via https://github.com/Gnucash/gnucash/commit/dda1bb83 (commit)
via https://github.com/Gnucash/gnucash/commit/fe57fc41 (commit)
via https://github.com/Gnucash/gnucash/commit/0dd406de (commit)
via https://github.com/Gnucash/gnucash/commit/0f3813e0 (commit)
via https://github.com/Gnucash/gnucash/commit/d4dfe4e2 (commit)
via https://github.com/Gnucash/gnucash/commit/0798bce2 (commit)
from https://github.com/Gnucash/gnucash/commit/9efbdc15 (commit)
commit ec6d38ae15297a108ff67190d8071912d9590871
Merge: 9efbdc15c 3a3cf05ab
Author: John Ralls <jralls at ceridwen.us>
Date: Thu Feb 16 12:29:05 2023 -0800
Merge Richard Cohen's 'fix-unused-1' into master.
commit 3a3cf05ab5a3b21ad6107a0d18c3ea5a0fca38b3
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 20:14:17 2023 +0000
Turn on -Wunused
commit 9c6ad222a907e86121cdfc4e48800b5da69bd810
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Sat Jan 28 16:22:16 2023 +0000
[-Wunused-function] - remove
commit 05975aa5102077ab478485162638d9e9da1e5f2b
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Sat Jan 28 16:00:00 2023 +0000
[-Wunused-function] - remove commented out reduce_tests() and dependents
commit f702709422bf21c1c868cf2324bd18344d035e8e
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Sat Jan 28 17:32:58 2023 +0000
[-Wunused-function] - make glade callbacks public
commit 1204083fdcefdbd8d2d5335de1551acfa7a58013
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 14:58:11 2023 +0000
[-Wunused-variable] - mark window limit as potentially unused (only on Mac)
commit 0aad5696793d98f858847b9c795db9b6b0fc4e17
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 14:44:51 2023 +0000
[-Wunused-variable] - mark QofLogModule as unused
commit 083166b5ffc42a34dc54f4f0b375063521a014ef
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 15:01:58 2023 +0000
[-Wunused-variable] - move into the #ifdef where it is used
commit 4eb022c7a2d5d521b8c04bf22b5b3bd43ac4afc0
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Jan 30 13:11:11 2023 +0000
[-Wunused-variable] - remove
commit 8a20bcadb079259fe76109908e91ef95e21ce17d
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Tue Jan 24 18:03:05 2023 +0000
[-Wunused-variable] - remove unused translatable string
commit 56d950598d65e56f1462038967886b0ec7a50c07
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Sat Jan 28 17:31:50 2023 +0000
[-Wunused-variable] - pretend to use
Looks like a SWIG bug, creating an extra variable that it doesn't use
bindings/python/gnucash_core.c: In function ‘_wrap_xaccAccountGetReconcileLastDate’:
bindings/python/gnucash_core.c:10096:10: warning: unused variable ‘secs20’ [-Wunused-variable]
10096 | time64 secs20 ;
| ^~~~~~
bindings/python/gnucash_core.c: In function ‘_wrap_xaccAccountGetReconcilePostponeDate’:
bindings/python/gnucash_core.c:10298:10: warning: unused variable ‘secs20’ [-Wunused-variable]
10298 | time64 secs20 ;
| ^~~~~~
bindings/python/gnucash_core.c: In function ‘_wrap_qof_query_date_predicate_get_date’:
bindings/python/gnucash_core.c:20237:10: warning: unused variable ‘secs20’ [-Wunused-variable]
20237 | time64 secs20 ;
| ^~~~~~
commit f63dddcc8483f3e273ffc4faf0cfa0c7b4f329d9
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 16:48:42 2023 +0000
[-Wunused-but-set-variable] (clang) - remove
commit dda1bb837407173c23374c6ed09bc3553fd6620c
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 17:45:34 2023 +0000
[-Wunused-but-set-variable] (clang) - use
commit fe57fc41838ebec188bdb3b3b76319879438df6e
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 16:42:10 2023 +0000
[-Wunused-but-set-variable] - remove
commit 0dd406de1030bd5501a6314996b592511aaf2273
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 18:27:39 2023 +0000
[-Wunused-lambda-capture] (clang) - remove
commit 0f3813e0fd4b0bf38d673df68590bf8a46a98ffd
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Mon Feb 13 16:49:25 2023 +0000
[-Wunused-private-field] (clang) - remove
In file included from gnucash/gnome-utils/dialog-options.cpp:34:
gnucash/gnome-utils/dialog-options.hpp:55:10: warning: private field 'toplevel' is not used [-Wunused-private-field]
bool toplevel;
^
In file included from gnucash/import-export/csv-imp/gnc-imp-props-price.cpp:42:
gnucash/import-export/csv-imp/gnc-imp-props-price.hpp:113:10: warning: private field 'created' is not used [-Wunused-private-field]
bool created = false;
^
libgnucash/backend/dbi/gnc-dbisqlconnection.cpp:53:29: warning: private field 'm_conn' is not used [-Wunused-private-field]
const GncSqlConnection* m_conn = nullptr;
^
libgnucash/backend/sql/test/utest-gnc-backend-sql.cpp:81:33: warning: private field 'm_conn' is not used [-Wunused-private-field]
const GncMockSqlConnection* m_conn;
^
commit d4dfe4e279b7a17251cd815091621f80708246d5
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Thu Jan 26 17:40:52 2023 +0000
[-Wunused-local-typedef] - remove
libgnucash/engine/test/utest-Account.cpp:2414:11: warning: typedef ‘using AcctTypeType = struct std::underlying_type<GNCAccountType>’ locally defined but not used [-Wunused-local-typedefs]
2414 | using AcctTypeType = std::underlying_type<GNCAccountType>;
| ^~~~~~~~~~~~
commit 0798bce2a6350d06de40992c0f40e5a039a7ccc5
Author: Richard Cohen <richard at daijobu.co.uk>
Date: Sat Jan 28 17:33:06 2023 +0000
[-Wunused-value] - remove
borrowed/jenny/jenny.c: In function ‘next_builder’:
borrowed/jenny/jenny.c:1164:5: warning: statement with no effect [-Wunused-value]
1164 | for (i; i<n-1; ++i) { /* reset all less significant positions */
| ^~~
borrowed/jenny/jenny.c:1172:5: warning: statement with no effect [-Wunused-value]
1172 | for (i; i<n-1; ++i) { /* reset all less significant positions */
| ^~~
borrowed/jenny/jenny.c: In function ‘confirm’:
borrowed/jenny/jenny.c:1797:7: warning: statement with no effect [-Wunused-value]
1797 | for (i; i<n-1; ++i) { /* reset all less significant positions */
| ^~~
borrowed/jenny/jenny.c:1805:7: warning: statement with no effect [-Wunused-value]
1805 | for (i; i<n-1; ++i) { /* reset all less significant positions */
| ^~~
libgnucash/backend/xml/io-gncxml-v2.cpp: In function ‘gboolean qof_session_load_from_xml_file_v2_full(GncXmlBackend*, QofBook*, sixtp_push_handler, gpointer, QofBookFileType)’:
libgnucash/backend/xml/io-gncxml-v2.cpp:806:40: warning: value computed is not used [-Wunused-value]
806 | g_thread_join (thread) != nullptr;
| ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
libgnucash/engine/Account.cpp: In function ‘void xaccFreeAccount(Account*)’:
libgnucash/engine/Account.cpp:1428:17: warning: statement has no effect [-Wunused-value]
1428 | priv->color == nullptr;
| ~~~~~~~~~~~~^~~~~~~~~~
libgnucash/engine/Account.cpp:1429:22: warning: statement has no effect [-Wunused-value]
1429 | priv->sort_order == nullptr;
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~
libgnucash/engine/Account.cpp:1430:17: warning: statement has no effect [-Wunused-value]
1430 | priv->notes == nullptr;
| ~~~~~~~~~~~~^~~~~~~~~~
libgnucash/engine/Account.cpp:1431:18: warning: statement has no effect [-Wunused-value]
1431 | priv->filter == nullptr;
| ~~~~~~~~~~~~~^~~~~~~~~~
libgnucash/engine/gnc-int128.cpp: In function ‘void decimal_from_binary(uint64_t*, uint64_t, uint64_t)’:
libgnucash/engine/gnc-int128.cpp:898:36: warning: right operand of comma operator has no effect [-Wunused-value]
898 | d[3] = (hi >> 32) & bin_mask, 0;
| ^
Summary of changes:
CMakeLists.txt | 6 +-
bindings/python/time64.i | 4 +
borrowed/jenny/jenny.c | 106 +-------------
gnucash/gnome-utils/dialog-account.c | 10 --
gnucash/gnome-utils/dialog-options.cpp | 11 --
gnucash/gnome-utils/dialog-options.hpp | 2 -
gnucash/gnome-utils/gnc-cell-view.c | 2 -
gnucash/gnome-utils/gnc-gtk-utils.c | 4 -
gnucash/gnome-utils/gnc-main-window.cpp | 13 +-
gnucash/gnome-utils/gnc-option-gtk-ui.cpp | 30 ----
gnucash/gnome-utils/gnc-plugin-page.c | 3 -
gnucash/gnome-utils/gnc-query-view.c | 2 -
gnucash/gnome-utils/gnc-report-combo.c | 9 +-
gnucash/gnome-utils/gnc-tree-view-account.c | 17 ---
gnucash/gnome-utils/gnc-tree-view.c | 5 -
gnucash/gnome/business-gnome-utils.c | 2 +-
gnucash/gnome/dialog-custom-report.c | 3 +-
gnucash/gnome/dialog-imap-editor.c | 18 ---
gnucash/gnome/dialog-payment.c | 7 -
gnucash/gnome/gnc-budget-view.c | 2 -
gnucash/gnome/gnc-plugin-budget.c | 2 -
gnucash/gnome/gnc-plugin-page-budget.c | 3 -
gnucash/gnome/gnc-plugin-page-invoice.c | 31 ----
gnucash/gnome/gnc-plugin-page-register.c | 22 ---
gnucash/gnome/reconcile-view.c | 2 -
gnucash/import-export/aqb/dialog-ab-trans.c | 19 +--
gnucash/import-export/bi-import/dialog-bi-import.c | 4 -
.../import-export/csv-imp/gnc-imp-props-price.hpp | 1 -
gnucash/import-export/csv-imp/gnc-imp-props-tx.cpp | 2 -
.../csv-imp/gnc-imp-settings-csv-price.cpp | 22 ---
gnucash/import-export/csv-imp/gnc-import-tx.cpp | 2 +-
gnucash/import-export/import-account-matcher.c | 11 --
gnucash/import-export/import-backend.cpp | 59 --------
gnucash/import-export/import-main-matcher.c | 33 +----
gnucash/import-export/log-replay/gnc-log-replay.c | 2 -
.../test/test-import-pending-matches.cpp | 2 +
.../register/ledger-core/split-register-model.c | 11 --
gnucash/register/register-core/quickfillcell.c | 3 -
.../register-gnome/gnucash-sheet-private.c | 24 ---
gnucash/register/register-gnome/gnucash-sheet.c | 21 +--
libgnucash/app-utils/gfec.c | 6 -
libgnucash/app-utils/gnc-quotes.cpp | 4 +-
libgnucash/backend/dbi/gnc-dbisqlconnection.cpp | 7 +-
libgnucash/backend/dbi/test/test-dbi-stuff.cpp | 5 -
libgnucash/backend/sql/gnc-slots-sql.cpp | 37 -----
libgnucash/backend/sql/gnc-transaction-sql.cpp | 162 ---------------------
.../backend/sql/test/utest-gnc-backend-sql.cpp | 6 +-
libgnucash/backend/xml/gnc-transaction-xml-v2.cpp | 10 --
libgnucash/backend/xml/io-gncxml-v2.cpp | 2 +-
libgnucash/core-utils/gnc-filepath-utils.cpp | 1 -
libgnucash/engine/Account.cpp | 8 +-
libgnucash/engine/Transaction.c | 19 ---
libgnucash/engine/gnc-int128.cpp | 2 +-
libgnucash/engine/gnc-optiondb.cpp | 49 -------
libgnucash/engine/kvp-frame.cpp | 2 +-
libgnucash/engine/policy.c | 37 -----
libgnucash/engine/qofobject.cpp | 6 -
libgnucash/engine/test-core/test-engine-stuff.cpp | 40 -----
libgnucash/engine/test-core/test-engine-stuff.h | 1 -
libgnucash/engine/test/test-gnc-date.c | 49 -------
libgnucash/engine/test/test-qofinstance.cpp | 9 --
libgnucash/engine/test/test-qofsession.cpp | 7 -
libgnucash/engine/test/utest-Account.cpp | 1 -
63 files changed, 43 insertions(+), 959 deletions(-)
More information about the gnucash-patches
mailing list