libgw-gnc.so missing

[Martijn Lina]

Hi,

I read a discussion between Derek Atkins and Oliver Burnett-Hall about a
missing libgw-gnc.so when installing gnucash:

https://lists.gnucash.org/pipermail/gnucash-user/2004-May/010390.html

After running into the same problem i took a deeper look into it because i
wasn't using prefix=<blabla> as an argument to make install. When looking at
what happened at install time, I noticed that the failure occured whet libtool
was relinking libgw-gnc-module.la. It seems that libtool assumes libgncmodule
had already been installed and as I was using DESTDIR, it wasn't...

The problem is the relink definition in the generated libgw-gnc-module.la,
which states libgncmodule.la without a path. When i added ./ before it, libtool
stopped complaining.

This little patch does it for me, i hope it can help other package builders:

--- gnucash-1.8.9.orig/src/gnc-module/Makefile.in	2004-04-12 07:26:20.000000000 +0200
+++ gnucash-1.8.9/src/gnc-module/Makefile.in	2004-08-06 12:36:37.875003056 +0200
@@ -247,7 +247,7 @@
 
 libgw_gnc_module_la_SOURCES = gw-gnc-module.c
 libgw_gnc_module_la_LDFLAGS = -module 
-libgw_gnc_module_la_LIBADD = libgncmodule.la \
+libgw_gnc_module_la_LIBADD = ./libgncmodule.la \
   ${G_WRAP_LINK_ARGS} \
   ${GUILE_LIBS} \
   ${GLIB_LIBS}


bye,
martijn.

> > On Fri, 2004-05-28 at 20:20, Derek Atkins wrote:
> >> What "make install" line are you using?
> >
> > make prefix=$startdir/pkg/usr install
> >
> > ($startdir is /var/lib/abs/local/gnucash)
> 
> Ahh!  Don't do that!  That's your problem.  You should never change
> "prefix" during the install phase.
> 
> Is this part of some packaging system?  Or do you want it to live in
> /var/lib/abs/local/gnucash?
> 
> If the former, then you should use DESTDIR (and you'll need to use
> LIBRARY_PATH -- see the RPM spec file for an example).  If the latter,
> then you don't need to set prefix at all during the install phase.
> 
> NEVER should you set 'prefix' during install.  In no world is it ever
> the "right way" to install into a separate subdir.
> 
> > - olly
> 
> > > -derek