GnuCash wont build anymore (From SVN)

[Tor Harald Thorland]

Derek Atkins wrote:

> FYI,
>
> I've just committed a patch to SVN that should cause the build
> to fail during the generation of gnc-svninfo if the "svn info"
> fails..   So could you "svn update" and rebuild and tell me what
> it does?
>
> Thanks,
>
> -derek
>
> Quoting Derek Atkins <warlord at MIT.EDU>:
>
>> Quoting Tor Harald Thorland <linux at strigen.com>:
>>
>>> As I said, I'm NOT a programmer, but what should the version definition
>>> look like?
>>
>>
>> If should be a number.
>>
>>> The thing here is that my last build was befor the following thing was
>>> changed.
>>
>>
>> Yes.  From "svn log gnc-splash.c":
>>
>> r11981 | hampton | 2005-11-19 18:53:34 -0500 (Sat, 19 Nov 2005) | 5
>> lines
>>
>> Include file cleanup.  Remove the messages.[ch] files in favor of the
>> glib supplied gi18n.h file.  Replace includes of gnome.h with gtk.h
>> (or better yet glib.h) wherever possible.  Don't include gnome.h from
>> any header files.  Remove some extraneous includes.
>>
>> ------------------------------------------------------------------------
>> r11964 | hampton | 2005-11-17 00:35:02 -0500 (Thu, 17 Nov 2005) | 1 line
>>
>> Update FSF street address.
>> ------------------------------------------------------------------------
>> r11789 | hampton | 2005-11-02 15:32:42 -0500 (Wed, 02 Nov 2005) | 3
>> lines
>>
>> Use a dynamically allocated string for the version.
>>
>>
>> The change that was made between 11964 and 11981 is this diff:
>>
>> --- gnc-splash.c        (revision 11964)
>> +++ gnc-splash.c        (working copy)
>> @@ -22,7 +22,8 @@
>>
>> #include "config.h"
>>
>> -#include <gnome.h>
>> +#include <gtk/gtk.h>
>> +#include <glib/gi18n.h>
>>
>> #include "gnc-gnome-utils.h"
>> #include "gnc-splash.h"
>>
>> That change wont have affected this.  Sorry.  No, the problem is /still/
>> not gnc-splash.c -- the problem is the generation of gnc-svninfo.h.  But
>> then again I said that already but you don't seem to believe me.
>>
>>> You can see using 'svn log src/gnome-utils/gnc-splash.c' that that
>>> file was changed on 2005-11-19 18:53:34 -0500.
>>
>>
>> Yes. see above.  it's an irrelevant change.
>>
>>> Does this output look correct?
>>>
>>> tortho at inspiron:~/SVN/gnucash$ svninfo=`svn info $$s |grep '^Revision:
>>> '|sed 's/Revision: //'` ;
>>> tortho at inspiron:~/SVN/gnucash$ echo "#define GNUCASH_SVN_REV $$svninfo"
>>> #define GNUCASH_SVN_REV 17734svninfo
>>> tortho at inspiron:~/SVN/gnucash$
>>
>>
>> No -- But what I handed you was a Makefile snippet and you're running
>> it under the shell.  So I'm not surprised it doesn't look right.  Try
>> running the following from your build directory src/gnome-utils:
>>
>>  svn info . | grep '^Revision: ' | sed 's/Revision: //'
>
>
Did run this, but no output. (It might be some other obvious things i
shall do with the next line but I'm not realy into this, both shell &
programming)
 svn info . | grep '^Revision: ' | sed 's/Revision: //'


But explain this! I did a svn update, and then builded the new version
of gnucash.

The splashscreen even showed the build ver 12015, so no problems...

WHY? Didn't you only supply a check for the version file..

Tor Harald