[GNC] Hidden accounts selection is erased when modifying a saved report

[Gal Bar Mashiah]

Won't it be possible to update the accounts selector to identify if it's a
case of a saved report configuration, and only in this case, to select
accounts according to the list of account GUIDs?

On Thu, Dec 21, 2023 at 5:50 AM john <jralls at ceridwen.us> wrote:

> It's a little more complicated than that.
>
> When you save a report configuration the accounts are saved as a list of
> account GUIDs.
>
> The new-for-5.x options system includes an accounts selector on all
> options dialogs and its default display doesn't include hidden accounts
> because they're hidden. Even if the selection list for the saved report
> configuration includes hidden accounts they won't be included in the
> selector and when you click apply or OK the callback for the accounts
> selector gets the new list and assumes that that's what the user wants,
> deselecting those hidden accounts. It has no way of knowing that the user
> didn't even look at the accounts page.  The account depth can have a
> similar effect.
>
> It works (or maybe breaks) the other way, too: Several reports use filters
> to generate default account selection, but if you save a report
> configuration it saves the list of accounts that matched the filter at the
> time the configuration is saved. If you later create an account that would
> match that filter and open the saved report config the new account won't be
> automatically included. You have to manually add it in the report options
> then re-save the config.
>
> This isn't very satisfactory but I haven't figured out a good way to fix
> it.
>
> Regards,
> John Ralls
>
>
> > On Dec 20, 2023, at 10:19, Adrien Monteleone <
> adrien.monteleone at lusfiber.net> wrote:
> >
> > What do you mean by 'created and saved'?
> >
> > Saving a report does not save its options as new defaults, just the
> rendering of the report with those options.
> >
> > A Saved Report Configuration is what you are looking for.
> >
> > If *that* is not really saving your options, then you found a bug.
> >
> > Note, to run a report with the Saved Configuration, you can't just run a
> default report from the regular menu entries, you have to run the report
> from the Saved Configuration list. Saving a configuration does not change
> default options.
> >
> > Regards,
> > Adrien
> >
> > On 12/20/23 9:57 AM, Gal Bar Mashiah wrote:
> >> When I create a report that includes hidden accounts, and later open it
> and
> >> modify something in the report options, the selection of the hidden
> >> accounts is erased.
> >> It may sound like an edge scenario but it happens a lot.
> >> For example I have a net worth report that shows the net worth from a
> time
> >> in the post until today, on a monthly basis.
> >> To create the report I had to choose hidden accounts of long past closed
> >> accounts.
> >> Back to the present, now I open the report but I want to change an
> option -
> >> it can be the date range, it can be a new account that didn't exist
> before,
> >> something it is even just displaying the result with a different
> currency.
> >> But when I do it, the accounts selection UI has the "Show Hidden
> Accounts"
> >> unchecked (even though it was checked when the report was created and
> >> saved) and as a result, all those hidden accounts get erased from the
> >> report after the modification is done.
> >> Is it intended? Is it a limitation? Should I create a bug in bugzilla?
> >
> > _______________________________________________
> > gnucash-user mailing list
> > gnucash-user at gnucash.org
> > To update your subscription preferences or to unsubscribe:
> > https://lists.gnucash.org/mailman/listinfo/gnucash-user
> > -----
> > Please remember to CC this list on all your replies.
> > You can do this by using Reply-To-List or Reply-All.
>
> _______________________________________________
> gnucash-user mailing list
> gnucash-user at gnucash.org
> To update your subscription preferences or to unsubscribe:
> https://lists.gnucash.org/mailman/listinfo/gnucash-user
> -----
> Please remember to CC this list on all your replies.
> You can do this by using Reply-To-List or Reply-All.
>