[Gnucash-changes] add some to-do notes for later

Linas Vepstas linas at cvs.gnucash.org
Mon Jul 26 18:44:10 EDT 2004


Log Message:
-----------
add some to-do notes for later

Modified Files:
--------------
    gnucash/src/engine:
        qofsession.c

Revision Data
-------------
Index: qofsession.c
===================================================================
RCS file: /home/cvs/cvsroot/gnucash/src/engine/qofsession.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -Lsrc/engine/qofsession.c -Lsrc/engine/qofsession.c -u -r1.14 -r1.15
--- src/engine/qofsession.c
+++ src/engine/qofsession.c
@@ -549,6 +549,11 @@
    * id and a lock on the file. */
 
   oldbooks = session->books;
+
+  /* XXX why are we creating a book here? I think the books
+   * need to be handled by the backend ... especially since 
+   * the backend may need to load multiple books ... XXX. FIXME.
+   */
   newbook = qof_book_new();
   session->books = g_list_append (NULL, newbook);
   PINFO ("new book=%p", newbook);
@@ -580,6 +585,11 @@
       }
   }
 
+  /* XXX if the load fails, then we try to restore the old set of books;
+   * however, we don't undo the session id (the URL).  Thus if the 
+   * user attempts to save after a failed load, they weill be trying to 
+   * save to some bogus URL.   This is wrong. XXX  FIXME.
+   */
   err = qof_session_get_error(session);
   if ((err != ERR_BACKEND_NO_ERR) &&
       (err != ERR_FILEIO_FILE_TOO_OLD) &&


More information about the gnucash-changes mailing list