gnucash maint: Multiple changes pushed
Christopher Lam
clam at code.gnucash.org
Fri Jun 4 12:21:17 EDT 2021
Updated via https://github.com/Gnucash/gnucash/commit/3353d395 (commit)
via https://github.com/Gnucash/gnucash/commit/a6ecd307 (commit)
from https://github.com/Gnucash/gnucash/commit/e0c6c76a (commit)
commit 3353d3950b9580aa81ca793822e566498a770353
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Jun 5 00:20:23 2021 +0800
[gnc-budget] g_value_unset GValue
diff --git a/libgnucash/engine/gnc-budget.c b/libgnucash/engine/gnc-budget.c
index 15df47596..4d9939abd 100644
--- a/libgnucash/engine/gnc-budget.c
+++ b/libgnucash/engine/gnc-budget.c
@@ -562,6 +562,7 @@ gnc_budget_is_account_period_value_set(const GncBudget *budget,
qof_instance_get_kvp (QOF_INSTANCE (budget), &v, 2, path_part_one, path_part_two);
if (G_VALUE_HOLDS_BOXED (&v))
ptr = g_value_get_boxed (&v);
+ g_value_unset (&v);
return (ptr != NULL);
}
@@ -571,6 +572,7 @@ gnc_budget_get_account_period_value(const GncBudget *budget,
guint period_num)
{
gnc_numeric *numeric = NULL;
+ gnc_numeric retval;
gchar path_part_one [GUID_ENCODING_LENGTH + 1];
gchar path_part_two [GNC_BUDGET_MAX_NUM_PERIODS_DIGITS];
GValue v = G_VALUE_INIT;
@@ -583,9 +585,9 @@ gnc_budget_get_account_period_value(const GncBudget *budget,
if (G_VALUE_HOLDS_BOXED (&v))
numeric = (gnc_numeric*)g_value_get_boxed (&v);
- if (numeric)
- return *numeric;
- return gnc_numeric_zero();
+ retval = numeric ? *numeric : gnc_numeric_zero ();
+ g_value_unset (&v);
+ return retval;
}
commit a6ecd30741e557ef05105682ab3498a70f6b48f6
Author: Christopher Lam <christopher.lck at gmail.com>
Date: Sat Jun 5 00:20:10 2021 +0800
[gnc-budget-view] free GList*
diff --git a/gnucash/gnome/gnc-budget-view.c b/gnucash/gnome/gnc-budget-view.c
index 43faf78f8..43326d073 100644
--- a/gnucash/gnome/gnc-budget-view.c
+++ b/gnucash/gnome/gnc-budget-view.c
@@ -297,6 +297,9 @@ gnc_budget_view_finalize (GObject *object)
priv = GNC_BUDGET_VIEW_GET_PRIVATE(budget_view);
+ g_list_free (priv->period_col_list);
+ g_list_free (priv->totals_col_list);
+
gnc_prefs_remove_cb_by_func (GNC_PREFS_GROUP_GENERAL, GNC_PREF_GRID_LINES_HORIZONTAL,
gbv_treeview_update_grid_lines, priv->totals_tree_view);
gnc_prefs_remove_cb_by_func (GNC_PREFS_GROUP_GENERAL, GNC_PREF_GRID_LINES_VERTICAL,
Summary of changes:
gnucash/gnome/gnc-budget-view.c | 3 +++
libgnucash/engine/gnc-budget.c | 8 +++++---
2 files changed, 8 insertions(+), 3 deletions(-)
More information about the gnucash-changes
mailing list