[Gnucash-changes] Remove guile - cashutil sync.

Brian dol-sen at telus.net
Sun Oct 2 02:22:28 EDT 2005


On Sat, 2005-01-10 at 17:27 -0400, Chris Shoemaker wrote:
> On Sat, Oct 01, 2005 at 09:43:29PM +0100, Neil Williams wrote:
> > On Saturday 01 October 2005 8:58 pm, Chris Shoemaker wrote:
> > > > +int
> > > > +main (int argc, char **argv)
> > > >  {
> > > > +	qof_init();
> > > > +	if(cashobjects_register()) {
> > > >    test_query_core();
> > > >    test_class();
> > > >    test_querynew();
> > 
> > Displays inline in each of the editors I use.
> > src/engine/test/test-querynew.c
> > 
> >         qof_init();
> >         if(cashobjects_register()) {
> >           test_query_core();
> >           test_class();
> >           test_querynew();
> >         }
> 
> Um, nobody cares what your editor shows you except you.  What matters
> is what's in the file.  When I said "please fix your editor" I meant:
> make it easier for you to detect when your change is inconsistent with
> the surrounding code.  Your patch will clearly produce a file with
> inconsistent indentation.  Readability matters.
> 
> I realize that it will be difficult for you to fix this
> after-the-fact.  I suggest reverting the patch until you can verify
> that your patches don't screw up indentation.
> 
> (BTW, consistent treatment of whitespace is necessary for
> collaboration in almost any software project.)
> 
> -chris
> _______________________________________________


Neil, Try changing the default tab size and see how YOUR editor shows
the inconsistencies.  I have been using scite for my main editor, it
shows when tabs are mixed with spaces in the same code block.  It also
has the option to use spaces in place of tabs when you use the tab key.
It helps keep things consistent.
-- 
Brian <dol-sen at telus.net>



More information about the gnucash-devel mailing list