Automake warnings in lib/goffice on Debian

[Christian Stimming]

Neil Williams schrieb:
>>Besides, you can switch off this particular annoying
>>"pointer-signedness-warnings" by -Wno-pointer-sign. That is probably the
>>best option for you.
> 
> 
> Aha! Thanks Christian. As you recommend, I would much rather ignore specific 
> warnings than ignore everything.
> 
> If I customise the Makefile.am's in this way, is there any harm in committing 
> the changes to main CVS or should I continue to enforce them only locally?

Only locally, please. I'd recomment that you set your environment 
variable CFLAGS accordingly. That variable should be picked up by 
configure et al.

(note: If it doesn't get picked up but gets overridden, then that's an 
error in the build system and needs to be fixed. CFLAGS should always be 
set by the user, whereas in the Makefile.am you only set AM_CFLAGS.)

>>I would advice against -Wno-error but rather switching off those
>>particular warnings as described above. OTOH of course goffice shouldn't
>>be fixed by us but rather by upstream.
> 
> 
> I think it's a case of our goffice being an incomplete copy of a snapshot that 
> is under continuing development. Each release breaks ours a little more.
> :-(

Or eventually due to the newer distributions we might decide that we 
accept their requirements. But I'm not into that issue, so I stay quiet 
about that...

Christian