[patch] libofx creates unbalanced tx on importing dividends bug 164645

[David Reiser]

The patch is attached to the bug report http://bugzilla.gnome.org/ 
show_bug.cgi?id=164645

gnc-ofx-import.c treats OFX_REINVEST (a transaction combining the  
payment of a dividend with the reinvestment of that dividend) and  
OFX_INCOME (a transaction of a security paying a dividend, resulting  
in cash being added to the parent brokerage account) the same despite  
the fact that, at least for my ofx downloads, the transaction amounts  
have opposite signs. The effect was that non-reinvested cash  
dividends were imported into gnucash unbalanced.

The patch fixes the behavior for me in 1.9.1. (Though I'm sure the  
coding style can only be considered brute force.) No more cursed hand  
editing of dividend transactions nor transactions added to "Imbalance- 
USD"!!!
--
David Reiser
dbreiser at earthlink.net
Mac 10.4.5, gcc 4.0.1