Notification mails for git repos - resend
jralls at ceridwen.us
Wed Feb 6 20:37:21 EST 2013
On Feb 6, 2013, at 12:41 PM, Geert Janssens <janssens-geert at telenet.be> wrote:
> Attached two updated notification mails. What has changed:
> - the mail sender is now set to the one pushing the commits to git. This is like it was in the svn generated mails
> - the commit hashes are now urls to the commit on github, similar to the way the commits in svn are urls to the commits on trac. It may be this generates very long lines in certain situations. We'll see.
> On 06-02-13 17:21, Geert Janssens wrote:
>> I'm resending this mail to ask for feedback. The previous attempt got side tracked by a discussion on BP/AUDIT and best practices in git.
>> Below you will find two sample mails as they will be generated from git when changes are pushed to the master repo. The will eventually replace the mails sent by svn as we currently see on gnucash-patches and gnucash-changes.
>> Can you guys and girls have a look at the mails and let me know what you think of the wording. Too vague ? Too verbose ? To technical ? Just right ?
You could use "short" commit numbers both for the subject line and the URLs e.g.,
works just fine, which will make it a bit more readable.
The preamble is way too long. The subject line says what the mail is about: Repo, branch, short changeset hash. The preamble can just be the changeset URL, again with the short hash. No need for the parent, there's a link to it on the Github change page.
Then the log entry, and for patch-mail, the patch.
More information about the gnucash-devel