[GNC-dev] Finance::Quote and the Toronto Stock Exchange

[Frank H. Ellenberger]

Hi Gord,

nice to see you thinking a step further. But at first I have a question:
Why was it renamed from TSX to TMX?

 From what I read in wikipedia the owner renamed itself a decade ago but 
not the market.

Also ISO 10383
https://www.iso20022.org/market-identifier-codes
has it still as TSX.

I would prefer, if the F::Q modules —where applicable— would follow this 
standard.

Am 26.11.22 um 20:40 schrieb gnu Gord:
> Hello List,
> I recently changed/fixed the module in Finance::Quote that queries the
> Toronto Stock Exchange for quotes (actually TMX). This change will be in
> the next release of FQ.
> I am unclear how to proceed from here as far as GnuCash is concerned.
> Should I create a pull request changing the file* gnc-commodity.c *It
> currently points to a module called "tsx" which does not exist.
> 
> Please forgive my fumbling questions, I'm new to all this.
> 
> Thanks,
> Gord

Yes, 
https://github.com/Gnucash/gnucash/blob/maint/libgnucash/engine/gnc-commodity.c#L227 
is the right place.

But usually you should also update the documentation:
The table <row> elements starting in
https://github.com/Gnucash/gnucash-docs/blob/maint/manual/C/tips-appendix.xml#L890;
https://github.com/Gnucash/gnucash-docs/blob/maint/manual/C/tips-appendix.xml#L1183
and the state <para>
https://github.com/Gnucash/gnucash-docs/blob/maint/manual/C/tips-appendix.xml#L1306

As it is only a change of a symbol in latin writing it is easy to patch 
also the other languages of the documentation.

Regards
Frank